T2b APPROVE

Clean implementation:

• New MarketCapBox client component properly isolates USD price and 24h change fetching
• Market cap formula correct: totalSupply * pricePerToken * plotUsd
• 24h change query uses 60s stale time, consistent with other price queries
• Returns null while plotUsd loads — no flash of incomplete data
• Supply Minted box untouched as required

No concerns.

Verdict: REQUEST CHANGES

Summary

The Market Cap UI change is close, but the new client component bypasses the repo's shared RPC configuration and hardcodes Base mainnet for the 24h change fetch.

Findings

• [medium] MarketCapBox creates its own createPublicClient({ chain: base, transport: http() }), which ignores NEXT_PUBLIC_CHAIN_ID and the shared fallback/CORS RPC setup in lib/rpc.ts. In Base Sepolia or any non-mainnet environment, this will fetch the 24h change from the wrong chain or fail inconsistently even though the rest of the app uses the environment-aware shared client.
  • File: src/components/MarketCapBox.tsx:11
  • Suggestion: Reuse the existing browser-safe client from lib/rpc.ts (or another shared chain-aware helper) instead of creating a hardcoded Base client inside the component.

Decision

Requesting changes because the current implementation introduces incorrect environment behavior in a shared storyline-header metric.

Verdict: REQUEST CHANGES

Summary

The chain-aware RPC fix is in place, but the storyline header refactor still leaves unused symbols behind in the page module.

Findings

• [medium] src/app/story/[storylineId]/page.tsx still imports UsdPriceTag even though the Token Price box was removed, and StoryHeader still declares const reserveLabel = RESERVE_LABEL; without using it. If the repo's lint step treats unused imports/locals as errors, this will fail lint-and-typecheck even though the runtime behavior is otherwise correct.
  • File: src/app/story/[storylineId]/page.tsx:26
  • File: src/app/story/[storylineId]/page.tsx:263
  • Suggestion: Remove the unused UsdPriceTag import and the unused reserveLabel local from StoryHeader.

Decision

Requesting changes because the PR still appears to contain a straightforward lint blocker after the refactor.

Verdict: APPROVE

Summary

The follow-up change resolves the remaining issues in the storyline header refactor: MarketCapBox now uses the shared browser RPC client, and the page module cleanup removed the unused import/local left behind by the Token Price replacement.

Findings

• None.

Decision

Approving because the Market Cap USD + 24h change box now matches issue #773 without the environment regression or lint blocker from the earlier revisions.